Admin Tools

#26944 Could you please record Country and Continent in full names in log files?

Posted in ‘Admin Tools for Joomla! 4 & 5’

This is a public ticket

Everybody will be able to see its contents. Do not include usernames, passwords or any other sensitive information.

Environment Information

Joomla! version

n/a

PHP version

n/a

Admin Tools version

n/a

Latest post by on Thursday, 23 February 2017 17:17 CST

Sunday, 22 January 2017 17:35 CST

baijianpeng

I noticed that in this log file "admintools_breaches.log" those country names and continent names are in "short code" format, for example:

-------------------------------------------------------------------------------

Blocking reason: adminpw

-------------------------------------------------------------------------------

Date/time : 2017-01-22 15:19:04 GMT

URL : http://joomlagate.com/administrator/index.php

User : Guest

IP : 170.210.88.17

Country : AR

Continent : SA

UA : Mozilla/4.0 (compatible; MSIE 6.00; Windows NT 5.1; SV1)

Could you please improve this feature to let Admin Tools record Country and Continent in full names in log files? Like "China" instead of "CN".

Thank you.

Monday, 23 January 2017 01:40 CST

nicholas

I really can't do that because it requires a hard-coded lookup table. This lookup table would have to be loaded on every page load of your site since it'd be part of the System - Admin Tools plugin. Worse yet, it'd have to be localizable (the country names should use the language of the email). This means that we need about 200 more language strings and about 200 translation lookups. While it doesn't sound like much, it does have a performance impact. Considering the marginal gains from showing the country name versus the measurable performance impact I'd rather not change the way it currently works.

Nicholas K. Dionysopoulos

Lead Developer and Director

🇬🇷Greek: native 🇬🇧English: excellent 🇫🇷French: basic • 🕐 My time zone is Europe / Athens
Please keep in mind my timezone and cultural differences when reading my replies. Thank you!

Monday, 23 January 2017 19:02 CST

baijianpeng

Understand now. Thank you.

Tuesday, 24 January 2017 00:40 CST

nicholas

You're welcome :)

Nicholas K. Dionysopoulos

Lead Developer and Director

Thursday, 23 February 2017 17:17 CST

System Task

system

This ticket has been automatically closed. All tickets which have been inactive for a long time are automatically closed. If you believe that this ticket was closed in error, please contact us.

Edited by on 2017-02-23 17:27 CST

Support