Support

Admin Tools

#24032 PHP File Change Scanner showing Admin Tools file different to zip

Posted in ‘Admin Tools for Joomla! 4 & 5’
This is a public ticket

Everybody will be able to see its contents. Do not include usernames, passwords or any other sensitive information.

Environment Information

Joomla! version
n/a
PHP version
n/a
Admin Tools version
n/a

Latest post by AlanHenness on Wednesday, 23 December 2015 15:43 CST

AlanHenness
 Hi

Using PHP File Change Scanner, set it up a few days ago and have now started to go through the files marked as suspicious.

Having problems with this one: libraries/fof/utils/ip/ip.php

The version on my site starts:
		<?php
/**
 * @package     FrameworkOnFramework
 * @subpackage  utils
 * @copyright   Copyright (C) 2010 - 2015 Nicholas K. Dionysopoulos / Akeeba Ltd. All rights reserved.
 * @license     GNU General Public License version 2 or later; see LICENSE.txt
 */

defined('FOF_INCLUDED') or die;

/**
 * IP address utilities
 */
abstract class FOFUtilsIp
{
	/** @var   string  The IP address of the current visitor */
	protected static $ip = null;

	/**
	 * Get the current visitor's IP address
	 *
	 * @return string
	 */
	public static function getIp()
	{
		if (is_null(static::$ip))
		{
			$ip = self::detectAndCleanIP();

Current checksum 05f32e28eb276bdf1482c0392ce79150

But I was checking it against the same file in a fresh download zip and it is slightly different:

<?php
/**
 * @package     FrameworkOnFramework
 * @subpackage  utils
 * @copyright   Copyright (C) 2010 - 2015 Nicholas K. Dionysopoulos / Akeeba Ltd. All rights reserved.
 * @license     GNU General Public License version 2 or later; see LICENSE.txt
 */

defined('F0F_INCLUDED') or die;

/**
 * IP address utilities
 */
abstract class F0FUtilsIp
{
	/** @var   string  The IP address of the current visitor */
	protected static $ip = null;

	/**
	 * Should I allow IP overrides through X-Forwarded-For or Client-Ip HTTP headers?
	 *
	 * @var    bool
	 */
	protected static $allowIpOverrides = true;

	/**
	 * Get the current visitor's IP address
	 *
	 * @return string
	 */
	public static function getIp()

A few lines after abstract class FOFUtilsIp are different. Why are they different?

There is another very similar file also in the suspicious list: libraries/f0f/utils/ip/ip.php (note the zero), but this isn't in the fresh downloaded zip file. Is this OK?

Thanks.

nicholas
Akeeba Staff
Manager
Please read https://www.akeebabackup.com/home/news/1558-info-about-fof-and-f0f.html

Now notice that you are comparing a file from FOF (old version, distributed with Joomla!) with a file from F0F (new version, distributed with our software). That's why they are different. And that also explains why you have libraries/fof and libraries/f0f. Do read the linked article, it explains everything in detail.

Nicholas K. Dionysopoulos

Lead Developer and Director

🇬🇷Greek: native 🇬🇧English: excellent 🇫🇷French: basic • 🕐 My time zone is Europe / Athens
Please keep in mind my timezone and cultural differences when reading my replies. Thank you!

AlanHenness
Argh. I didn't notice that. Thanks for pointing it out.

Alan

Support Information

Working hours: We are open Monday to Friday, 9am to 7pm Cyprus timezone (EET / EEST). Support is provided by the same developers writing the software, all of which live in Europe. You can still file tickets outside of our working hours, but we cannot respond to them until we're back at the office.

Support policy: We would like to kindly inform you that when using our support you have already agreed to the Support Policy which is part of our Terms of Service. Thank you for your understanding and for helping us help you!